Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Example showing how to use AsyncComputeTaskPool and Tasks #2180

Closed
wants to merge 23 commits into from
Closed

[Merged by Bors] - Example showing how to use AsyncComputeTaskPool and Tasks #2180

wants to merge 23 commits into from

Conversation

the-notable
Copy link
Contributor

No description provided.

@alice-i-cecile alice-i-cecile added A-Core Common functionality for all bevy apps C-Examples An addition or correction to our examples labels May 16, 2021
@alice-i-cecile
Copy link
Member

Also needs to be added to the examples README :)

the-notable and others added 2 commits May 15, 2021 20:48
@the-notable @NathanSWard
Update examples/tasks/async_compute.rs
d5218ed 
Co-authored-by: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
@the-notable @NathanSWard
Update examples/tasks/async_compute.rs
271e3b5 
Co-authored-by: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
the-notable and others added 2 commits May 15, 2021 21:02
@the-notable @NathanSWard
Update examples/tasks/async_compute.rs
bf093ef 
Co-authored-by: Nathan Ward <43621845+NathanSWard@users.noreply.github.com>
@the-notable
removed unnecessary space
0c400d2
@NathanSWard NathanSWard added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 19, 2021
@mockersf
Copy link
Member

bors try

bors bot added a commit that referenced this pull request May 19, 2021
@bors
Try #2180:
c2e78e8
@bors
Copy link
Contributor

bors bot commented May 19, 2021

try

Build failed:

@mockersf
Copy link
Member

Could you run cargo fmt(or even better, cargo run -p ci)?

@NathanSWard NathanSWard removed the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 19, 2021
@the-notable
Copy link
Contributor Author

Could you run cargo fmt(or even better, cargo run -p ci)?

Done, passes now

@NathanSWard
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 20, 2021
@bors
Try #2180:
51f1078
@bors
Copy link
Contributor

bors bot commented May 20, 2021

try

Build succeeded:

@NathanSWard NathanSWard added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 20, 2021
cart
cart reviewed May 20, 2021
View reviewed changes
examples/async_tasks/async_compute.rs Outdated Show resolved Hide resolved
examples/async_tasks/async_compute.rs Outdated Show resolved Hide resolved
examples/async_tasks/async_compute.rs Outdated Show resolved Hide resolved
@mockersf
Copy link
Member

bors try

bors bot added a commit that referenced this pull request May 21, 2021
@bors
Try #2180:
db53380
@bors
Copy link
Contributor

bors bot commented May 21, 2021

try

Build succeeded:

@cart
Copy link
Member

cart commented May 23, 2021

bors r+

bors bot pushed a commit that referenced this pull request May 23, 2021
@the-notable
Example showing how to use AsyncComputeTaskPool and Tasks (#2180)
9f94f7e
@bors
Copy link
Contributor

bors bot commented May 23, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Example showing how to use AsyncComputeTaskPool and Tasks [Merged by Bors] - Example showing how to use AsyncComputeTaskPool and Tasks May 23, 2021
@bors bors bot closed this May 23, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@the-notable @ostwilkens
Example showing how to use AsyncComputeTaskPool and Tasks (bevyengine…
9ef761d 
…#2180)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@NathanSWard NathanSWard NathanSWard approved these changes

@TheRawMeatball TheRawMeatball TheRawMeatball approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Core Common functionality for all bevy apps C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@the-notable @alice-i-cecile @mockersf @NathanSWard @cart @TheRawMeatball